This repository was archived by the owner on Feb 13, 2025. It is now read-only.
GH-112498 Add heapremove and heapfix#307
Closed
kristjanvalur wants to merge 10000 commits into
Closed
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to python#112497 which adds two functions, heapfix and heapremove.
This is perhaps better, since the use cases are slightly similar. heappop becomes a special case of heapremove, and
it corresponds to what golang does in https://pkg.go.dev/container/heap